https://bugzilla.redhat.com/show_bug.cgi?id=1392599 Jared Wallace <jared-wallace@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jared-wallace@xxxxxxxxxx --- Comment #2 from Jared Wallace <jared-wallace@xxxxxxxxxx> --- **This is an unofficial review** Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues ============== 1) *MUST* The description has lines exceeding 79 characters. Please split them across multiple lines to avoid this. 2) *MUST* The README.txt has incorrect end-of-line encoding. You can fix this with the following command: sed -i 's/\r$//' README.txt 3) *SHOULD* Consider writing a manpage for this so people understand how to use it. Here's a guide: http://www.schweikhardt.net/man_page_howto.html 4) *SHOULD* The link you have to the spec file is not linked to the "raw" spec file, but rather the Git page - it's better to link to the raw version. That way when people click to save the link, they get the spec file and not HTML. 5) *SHOULD* You do not need the line "rm -rf %{buildroot}" 6) *OPTIONAL* Consider using copr to build this as outlined here: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Make_a_Package 7) *MUST* The source file mcrcon.c in your src rpm and the upstream source are different. I suspect because the source url you have is for SourceForge, and not the upstream github repo, which is here: https://github.com/Tiiffi/mcrcon Everything else seems to be alright. Good luck :) (rest of the review below can be ignored, all issues are enumerated above) ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "zlib/libpng". Detailed output of licensecheck in /tmp/pkg- review/mcrcon/mcrcon/licensecheck.txt [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mcrcon-0.0.5-2.fc24.x86_64.rpm mcrcon-0.0.5-2.fc24.src.rpm mcrcon.x86_64: W: spelling-error Summary(en_US) rcon -> econ, con, recon mcrcon.x86_64: W: spelling-error Summary(en_US) minecraft -> mine craft, mine-craft, craftiness mcrcon.x86_64: W: spelling-error %description -l en_US minecraft -> mine craft, mine-craft, craftiness mcrcon.x86_64: W: spelling-error %description -l en_US rcon -> econ, con, recon mcrcon.x86_64: W: spelling-error %description -l en_US bukkit -> kabuki mcrcon.x86_64: E: description-line-too-long C Mcrcon is powerful IPv6 compliant minecraft rcon client with bukkit coloring support. mcrcon.x86_64: E: description-line-too-long C It is well suited for remote administration and to be used as part of automated server maintenance scripts. mcrcon.x86_64: E: description-line-too-long C Does not cause "IO: Broken pipe" or "IO: Connection reset" spam in server console. mcrcon.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/mcrcon/README.txt mcrcon.x86_64: W: no-manual-page-for-binary mcrcon mcrcon.src: W: spelling-error Summary(en_US) rcon -> econ, con, recon mcrcon.src: W: spelling-error Summary(en_US) minecraft -> mine craft, mine-craft, craftiness mcrcon.src: W: spelling-error %description -l en_US minecraft -> mine craft, mine-craft, craftiness mcrcon.src: W: spelling-error %description -l en_US rcon -> econ, con, recon mcrcon.src: W: spelling-error %description -l en_US bukkit -> kabuki mcrcon.src: E: description-line-too-long C Mcrcon is powerful IPv6 compliant minecraft rcon client with bukkit coloring support. mcrcon.src: E: description-line-too-long C It is well suited for remote administration and to be used as part of automated server maintenance scripts. mcrcon.src: E: description-line-too-long C Does not cause "IO: Broken pipe" or "IO: Connection reset" spam in server console. 2 packages and 0 specfiles checked; 6 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory mcrcon.x86_64: W: spelling-error Summary(en_US) rcon -> econ, con, recon mcrcon.x86_64: W: spelling-error Summary(en_US) minecraft -> mine craft, mine-craft, craftiness mcrcon.x86_64: W: spelling-error %description -l en_US minecraft -> mine craft, mine-craft, craftiness mcrcon.x86_64: W: spelling-error %description -l en_US rcon -> econ, con, recon mcrcon.x86_64: W: spelling-error %description -l en_US bukkit -> kabuki mcrcon.x86_64: E: description-line-too-long C Mcrcon is powerful IPv6 compliant minecraft rcon client with bukkit coloring support. mcrcon.x86_64: E: description-line-too-long C It is well suited for remote administration and to be used as part of automated server maintenance scripts. mcrcon.x86_64: E: description-line-too-long C Does not cause "IO: Broken pipe" or "IO: Connection reset" spam in server console. mcrcon.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/mcrcon/README.txt mcrcon.x86_64: W: no-manual-page-for-binary mcrcon 1 packages and 0 specfiles checked; 3 errors, 7 warnings. Requires -------- mcrcon (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) Provides -------- mcrcon: mcrcon mcrcon(x86-64) Source checksums ---------------- http://downloads.sourceforge.net/mcrcon/mcrcon-0.0.5-src.zip : CHECKSUM(SHA256) this package : 14cdbc00d5e2c4e877ea82fef3aeb94c2e258b3539c47a7f2b015cab12f98a74 CHECKSUM(SHA256) upstream package : 14cdbc00d5e2c4e877ea82fef3aeb94c2e258b3539c47a7f2b015cab12f98a74 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -rn mcrcon-0.0.5-2.fc26.src.rpm Buildroot used: fedora-24-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx