https://bugzilla.redhat.com/show_bug.cgi?id=1344276 Sachidananda Urs <surs@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |surs@xxxxxxxxxx --- Comment #5 from Sachidananda Urs <surs@xxxxxxxxxx> --- (In reply to Ken Dreyer from comment #4) > Would you please address each of Parag's comments above and update the > package to the latest upstream version? Ack! I will do that. > > I'm a sponsor, so I can sponsor you if you would please do one satisfactory > unofficial review of a package in Parag's links above, and ensure that this > package gets cleaned up. Sure, I will do that. Thanks for this. > > For example, this sort of boilerplate seems common in the Gluster community > and is unneeded: > > %define name gdeploy > %define version 2.1 > %define release 0 > > In fact it will break tools like rpmdev-bumpspec that Fedora rel-eng uses > for mass rebuilds. It's better to simply define the values directly in the > RPM: > > Name: gdeploy > Version: 2.1 > Release: 1%{?dist} > > The URL should be the upstream project, https://github.com/gluster/gdeploy, > not Red Hat's storage website. Sure. I will make these changes. Thanks for helping on this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx