https://bugzilla.redhat.com/show_bug.cgi?id=1344276 --- Comment #6 from Sachidananda Urs <surs@xxxxxxxxxx> --- (In reply to Parag AN(पराग) from comment #2) > Suggestions: > As per current packaging guidelines given on > https://fedoraproject.org/wiki/Packaging:Guidelines > > 1) use %global instead of %define, See > https://fedoraproject.org/wiki/Packaging:Guidelines#. > 25global_preferred_over_.25define > Done. > 2) In %install, following is now optional and should be removed > rm -rf %{buildroot} > > as per https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections > Done. > 3) Group and BuildRoot tag are not needed now, remove them. > Done. > 4) Good to write every Require: per line > Done. > 5) Why every package in Requires: need hard versioned requirement? I think > whatever packages are in Fedora should satisfy the requirements and make > this package run without any issues. Onlyif it needs some different version > then that issue need to be fixed like some package need higher version and > if its not yet in Fedora then that package should be updated to that higher > version thus no need to write explicit versions > Makes sense. However we need version information for Ansible. Fedora ships 1.x, we need 2.x. > 6) You need to go through https://fedoraproject.org/wiki/Packaging:Python > which can tell you we now use explicitly "python2" wherever you have used > "python" Done. > > 7) we don't need now %clean section, remove it Ack. > > 8) You may write your spec accordingly python packaging guidelines. > > 9) I can't find the 2.1.0 tarball on the given source location, fix this > This should not be a problem in future. I will make changes to point to git tags. > Submit new SPEC and SRPM by fixing above issues and adding new changelog > entry. Every time you make some change in SPEC, you need to update the > release tag and add changelog. Sure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx