[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1344276

Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktdreyer@xxxxxxxxxxxx



--- Comment #4 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> ---
Would you please address each of Parag's comments above and update the package
to the latest upstream version?

I'm a sponsor, so I can sponsor you if you would please do one satisfactory
unofficial review of a package in Parag's links above, and ensure that this
package gets cleaned up.

For example, this sort of boilerplate seems common in the Gluster community and
is unneeded:

  %define name gdeploy
  %define version 2.1
  %define release 0

In fact it will break tools like rpmdev-bumpspec that Fedora rel-eng uses for
mass rebuilds. It's better to simply define the values directly in the RPM:

  Name:           gdeploy
  Version:        2.1
  Release:        1%{?dist}

The URL should be the upstream project, https://github.com/gluster/gdeploy, not
Red Hat's storage website.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]