[Bug 1373155] Review Request: perl-Test-Toolbox - Tools for testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1373155



--- Comment #3 from Jan Pazdziora <jpazdziora@xxxxxxxxxx> ---
Thank you for the review. New versions of .spec and .src.rpm were put to

Spec URL: https://adelton.fedorapeople.org/perl-Test-Toolbox.spec
SRPM URL: https://adelton.fedorapeople.org/perl-Test-Toolbox-0.4-1.fc24.src.rpm

The .spec diff against the first take is

--- perl-Test-Toolbox.spec.take1    2016-09-05 13:23:09.668485126 +0200
+++ perl-Test-Toolbox.spec    2016-09-06 16:45:46.474393197 +0200
@@ -8,17 +8,20 @@
 Source0:       
http://www.cpan.org/modules/by-module/Test/Test-Toolbox-%{version}.tar.gz
 BuildArch:      noarch

+BuildRequires:  coreutils
 BuildRequires:  findutils
 BuildRequires:  make
 BuildRequires:  perl
 BuildRequires:  perl(base)
 BuildRequires:  perl(Carp)
+BuildRequires:  perl(Exporter)
 BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(strict)
 BuildRequires:  perl(Test::Builder::Module)
 BuildRequires:  perl(Cwd)
 BuildRequires:  perl-generators

+Requires:       perl(File::Basename)
 Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))

 %description
@@ -36,7 +39,7 @@
 make %{?_smp_mflags}

 %install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=%{buildroot}

 find $RPM_BUILD_ROOT -type f -name .packlist -delete

@@ -52,5 +55,5 @@
 %{_mandir}/man3/*

 %changelog
-* Mon Sep 05 2016 Jitka Plesnikova <jplesnik@xxxxxxxxxx> - 0.4-1
+* Mon Sep 05 2016 Jan Pazdziora <jpazdziora@xxxxxxxxxx> - 0.4-1
 - 1370828 dependency - Initial .spec for 0.4.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]