[Bug 1373155] Review Request: perl-Test-Toolbox - Tools for testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1373155

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
@@ -36,7 +39,7 @@
 make %{?_smp_mflags}

 %install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=%{buildroot}

 find $RPM_BUILD_ROOT -type f -name .packlist -delete

FIX: Please replace '%{buildroot} by '$RPM_BUILD_ROOT' to be consistent and not
use these two macros in one spec.


Other changes are ok.

Please correct the 'FIX' issue. 

Otherwise package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]