[Bug 1373155] Review Request: perl-Test-Toolbox - Tools for testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1373155



--- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

FIX: Please add following build-requires
     - coreutils - perl-Test-Toolbox.spec:32
     - perl(Exporter) - Test-Toolbox-0.4/lib/Test/Toolbox.pm:108

$ rpm -qp --requires perl-Test-Toolbox-0.4-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(Cwd)
      1 perl(Exporter)
      1 perl(Test::Builder::Module)
      1 perl(base)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

FIX: Please add missing run-require perl(File::Basename) it is used 
     in Test-Toolbox-0.4/lib/Test/Toolbox.pm:176

$ rpm -qp --provides perl-Test-Toolbox-0.4-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Test::Toolbox) = 0.4
      1 perl-Test-Toolbox = 0.4-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Test-Toolbox*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.

FIX: Please replace my name by your name in changelog.

Please correct all 'FIX' issues and consider fixing 'TODO' items and
provide new spec file.

Package is not approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]