[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1372866



--- Comment #27 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
(In reply to Ralf Corsepius from comment #25)
> The origin of this mess the toplevel CMakeList.txt, which is entirely broken.

Jason asked me off-list to elaborate this

In lines 179-244, this CMakeList.txt implements a scheme which manipulates and
overrides CFLAGS/CXXFLAGS to values which are incompatible to Fedora (== this
package is being miscompiled). This alone qualifies this package as
non-eligible for Fedora, unless this issue can be worked around.

Besides this, the working principle of this cmake section lacks generality and
lacks portability (As you found out when building for the arm). 

To allow for users to specify their desired *CLAGS, most cmake-packages are
equipped the a cmake define which lets users specify "his *FLAGS" (Often "build
type"). Unfortunately, this package doesn't seem fall into this category.

I.e. it's likely necessary to patch CMakeList.txt to move the harmful parts
out.

(In reply to Jon Ciesla from comment #26)
> Package request has been approved:
> https://admin.fedoraproject.org/pkgdb/package/rpms/hyperscan
Sigh - I like should have reset the cvs-flags :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]