[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #25 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
(In reply to Yaniv Bronhaim from comment #2)
[...]
> >>vdsm.spec:768: E: hardcoded-library-path in %{buildroot}/usr/lib/systemd/systemd-vdsmd
> vdsm.spec:769: E: hardcoded-library-path in
> %{buildroot}/usr/lib/systemd/system-preset/85-vdsmd.preset
> vdsm.spec:904: E: hardcoded-library-path in /usr/lib/systemd/systemd-vdsmd
> vdsm.spec:905: E: hardcoded-library-path in
> /usr/lib/systemd/system-preset/85-vdsmd.preset
> 
> Using %{_libdir} now

Please note that there's no /usr/lib64/systemd, so using %{_libdir} is actually
wrong in this case.

> >>vdsm.spec: W: invalid-url Source0: vdsm-4.18.999.tar.gz
> 
> Changed to https://bronhaim.fedorapeople.org/%{vdsm_name}-%{version}.tar.gz
> and I'll upload the tar there

Is there no upstream project with releases for this? Having a source without an
URL is acceptable if justified. A method of obtaining the source tarball should
be provided in a comment or a tarball generation script should be provided.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]