[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1361659



--- Comment #24 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
Speaking just for myself now, I note that this package should not have passed
review for other reasons as well.

1. rpmlint errors and warnings were not addressed at all. I can see some of
them being noted, but they're not fixed in the package.
2. Debug package is disabled with a wrong justification. It doesn't matter that
the main package is only a metapackage, binary debuginfo from all subpackages
will be collected into vdsm-debuginfo automatically. If all subpackages are
noarch, then just BuildArch: noarch in the main package is enough and should be
removed from all subpackages.
3. ExclusiveArch is not explained (and you should use ExcludeArch: instead
unless it's well-justified).
4. Obsolete BR: systemd-units.
5. Unexplained %ifarch x86_64 in line 127.
6. Unexplained Conflicts: in line 275.

And that's after a quick look at the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]