https://bugzilla.redhat.com/show_bug.cgi?id=1361659 --- Comment #26 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Some additional nits: Python subpackage (%package python) is named incorrectly (it should be %package -n python2-vdsm). %changelog is not in the prescribed format. Why are you packaging tests? The proliferation of subpackages is quite concerning. Please explain why it doesn't make sense to merge all subpackages that do not bring in additional dependencies into the main package, namely: api hook-allocate_net hook-checkimages hook-checkips hook-diskunmap hook-ethtool-options hook-extnet hook-extra-ipv4-addrs hook-fakesriov hook-fakevmstats hook-faqemu hook-floppy hook-hugepages hook-ipv6 hook-isolatedprivatevlan hook-macbind hook-macspoof hook-nestedvt hook-noipspoof hook-numa hook-openstacknet hook-pincpu hook-promisc hook-qemucmdline hook-qos hook-scratchpad hook-smbios hook-spiceoptions hook-vmdisk hook-vmfex/hook-vmfex-dev (why do they conflict?) xmlrpc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx