https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #9 from yunying.sun@xxxxxxxxx --- (In reply to Ralf Corsepius from comment #8) > (In reply to yunying.sun from comment #4) > > the configure error "cannot run C compiled programs" is there, seems because > > "%configure" adds an extra flag "-Werror" to CFLAGS, which turns some config > > warnings to errors. With "./configure", koji build pass. > > > > @Igor, is it acceptable to use: > > CONFIG_SITE=$(pwd)/lib/default_config.site ./configure > > #%configure > > > > instead of: > > export CONFIG_SITE=$(pwd)/lib/default_config.site > > %configure > > Neither is acceptable. Both ways disable checks configure performs and use > cached values instead - This way you are tricking yourself by outsmarting > configure. Thanks Ralf for your comment. @Ralf, if neither is acceptable, could you point the right way of configuring? > > Furthermore: > > - ./bootstrap belongs into %prep not %configure Will move ./bootstrap to %prep. > > - Fedora packages must not install anything into /usr/local. > I.e. this is not allowed in fedora: > %files > %{_prefix}/local/sbin/tpm2_* You must be seeing the other SPEC file - tpm2-tools.spec. There's another bz for it: https://bugzilla.redhat.com/show_bug.cgi?id=1369720 I will fix the "/usr/local" issue then update tpm2-tools.spec. > > - Your src.rpm fails to build for fedora due to missing BuildRequires. > You'd have to submit these packages. Yes, tpm2-tools.srpm fails to build due to missing BuildRequires for package "tpm2-tss" & "tpm2-tss-devel". To make tpm2-tools koji build PASS, does it has to wait until tpm2-tss & tpm2-tss-devel get integrated? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx