https://bugzilla.redhat.com/show_bug.cgi?id=1307271 --- Comment #9 from Giovanni <dacav@xxxxxxxxxxxxxxx> --- Hi Diogo, Sorry for the delay, I'm quite busy those days. Anyway, I've got some comments for you: 1) The license of your package is AGPL3+, while the SPEC file claims GPLv3. This is probably useful: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing Also the configuration file upstream seems to be licensed with GPL3. Out of curiosity, any particular reason why you decided for Affero? This is not a web application… 2) Python has some specific guidelines which you should follow: https://fedoraproject.org/wiki/Packaging:Python - The %build section is missing (rpmlint is giving you a warning for this). - Your script should use a she-bang without env, e.g. #!/usr/bin/python2 - "BuildRequires: python2-devel" is needed. I was wondering if this also holds here, since you don't have a setup.py. I've verified it does by asking in #fedora-python. - You shouldn't "Requires: python" directly - Would it be possible to use python3 instead of python2? I've still to go through the whole document, so there could be more details to care about. 3) According to what I see in the following link, the changelog entries apparently separate the email from the version with a dash. I'm not really sure this is a problem (rpmlint is not complaining about this), so this is probably not important. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs A non-packager related point: the code is not doing any error checking. I suggest you to run subcommands with the `subprocess` module so you can conveniently check the outcome of the subprocess execution. Cheers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx