[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1369708

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #8 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
(In reply to yunying.sun from comment #4)
> the configure error "cannot run C compiled programs" is there, seems because
> "%configure" adds an extra flag "-Werror" to CFLAGS, which turns some config
> warnings to errors. With "./configure", koji build pass.
> 
> @Igor, is it acceptable to use:
> CONFIG_SITE=$(pwd)/lib/default_config.site ./configure
> #%configure
> 
> instead of:
> export CONFIG_SITE=$(pwd)/lib/default_config.site
> %configure

Neither is acceptable. Both ways disable checks configure performs and use
cached values instead - This way you are tricking yourself by outsmarting
configure.

Furthermore:

- ./bootstrap belongs into %prep not %configure

- Fedora packages must not install anything into /usr/local.
I.e. this is not allowed in fedora:
%files
%{_prefix}/local/sbin/tpm2_*

- Your src.rpm fails to build for fedora due to missing BuildRequires. 
  You'd have to submit these packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]