https://bugzilla.redhat.com/show_bug.cgi?id=1364618 --- Comment #19 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #16) > You don't need to delete an empty dir from the installation root, rpm will > just ignore it. Good to know. > Something is wrong with the way CXXFLAGS are set (right after pushd). Before > it before %cmake and that was working better. Do you mean CXXFLAGS before %cmake? > %files is still busted. See #c14 for the right form :) > rpmlint goes all crazy: > embree-devel.x86_64: E: non-devel-file-in-devel-package > /usr/lib64/libembree.so.2.10.0 > embree-devel.x86_64: E: library-without-ldconfig-postin > /usr/lib64/libembree.so.2.10.0 > embree-devel.x86_64: E: library-without-ldconfig-postun > /usr/lib64/libembree.so.2.10.0 Fixed. > You cannot install the examples into /usr/bin. The names are too generic: > e.g. /usr/bin/convert is a well-known imagemagick executable. You can use > %_libdir/embree/examples instead. %{_libexecdir}/embree is used instead. > - rpmlint is not happy (see above and below) > > rpmlint: > embree.src:54: W: mixed-use-of-spaces-and-tabs (spaces: line 54, tab: line 1) Weird. rpmlint n my side did not complain about that line. Either way, it is fixed. Here is the updated files: Spec URL: https://luya.fedorapeople.org/packages/SPECS/embree.spec SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/embree-2.10.0-6.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx