[Bug 879740] Review Request: python-evdev - bindings for the linux input handling subsystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=879740



--- Comment #14 from gvalkov <georgi.t.valkov@xxxxxxxxx> ---
Thanks you for the review, Zbigniew. Those were all very valid points, which I
hope to have addressed in the latest version of the spec:

Spec URL:
https://raw.githubusercontent.com/gvalkov/python-evdev/436a967967a862481d7e34c5d243a67351d84500/packaging/python-evdev.spec
SRPM URL:
https://gvalkov.fedorapeople.org/python-evdev/python-evdev-0.6.1-1.fc24.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15326372

This is the diff:
https://github.com/gvalkov/python-evdev/commit/436a967967a862481d7e34c5d243a67351d84500

> rpmlint python-evdev.spec 
> 0 packages and 1 specfiles checked; 0 errors, 0 warnings.

> rpmlint python3-evdev-0.6.1-1.fc24.x86_64.rpm
> python3-evdev.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace
> python3-evdev.x86_64: W: spelling-error %description -l en_US dev -> deb, derv, div
> python3-evdev.x86_64: W: spelling-error %description -l en_US uinput -> input, u input, Putin
> python3-evdev.x86_64: W: spelling-error %description -l en_US Uinput -> Input, U input, Putin
> python3-evdev.x86_64: E: wrong-script-interpreter /usr/lib64/python3.5/site-packages/evdev/genecodes.py /usr/bin/env python
> python3-evdev.x86_64: E: non-executable-script /usr/lib64/python3.5/site-packages/evdev/genecodes.py 644 /usr/bin/env python
> python3-evdev.x86_64: E: wrong-script-interpreter /usr/lib64/python3.5/site-packages/evdev/evtest.py /usr/bin/env python
> python3-evdev.x86_64: E: non-executable-script /usr/lib64/python3.5/site-packages/evdev/evtest.py 644 /usr/bin/env python
> 1 packages and 0 specfiles checked; 4 errors, 4 warnings.

Imho, these don't matter, as genecodes and evtest aren't execv-ed as scripts
(anymore). I simply forgot to remove the shebang when I made them into
executable modules (i.e. python -m evdev.evtest). I'll fix this upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]