[Bug 1364618] Review Request: embree - Collection of high-performance ray tracing kernels developed at Intel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1364618

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #20 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
In %files, change %{_libexecdir}/%{name}/* to %{_libexecdir}/%{name}/,
otherwise the directory is going to be unowned.

I don't think the tests do anything:
+ ctest -V -j12
UpdateCTestConfiguration  from
:/builddir/build/BUILD/embree-2.10.0/DartConfiguration.tcl
UpdateCTestConfiguration  from
:/builddir/build/BUILD/embree-2.10.0/DartConfiguration.tcl
Test project /builddir/build/BUILD/embree-2.10.0
Constructing a list of tests
Checking test dependency graph...
Checking test dependency graph end
No tests were found!!!
+ exit 0

You can run benchmark as a test instead.

+ package name is OKt
+ license is acceptable (ASL 2.0)
+ license is specified correctly 
+ latest version
+ builds and install OK
+ provides/requires/BR look OK
+ rpmlint is happy
+ scriptlets look OK

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]