Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Pygments - A syntax highlighting engine written in Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246312 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-30 03:01 EST ------- If the package is named "python-pygments" then the spec file needs to be named "python-pygments.spec". The LICENSE file seems to me to be a regular 3-clause BSD license. Where did you see the LGPL? There's no need to manually require python; rpm finds the python(abi) requirement on its own. You should use %{_bindir} instead of /usr/bin and %{_mandir} instead of /usr/share/man in your %files section. I have to say I've not seen any package placing English manpages in a language-specific directory. My rawhide system has 26 manpages under /usr/share/man/en (so I suppose it's not unheard of) and about 10500 in /usr/share/man. Review: * source files match upstream: c1394c794a8c3056ff581ccc09d089a3d99fb9d6a44e03eaac4165365b8f2707 Pygments-0.8.1.tar.gz * package meets naming and versioning guidelines. X specfile is not properly named. * summary is OK. * description is OK. * dist tag is present. * build root is OK. X license field says LGPL but the license is BSD * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. ? final provides and requires are sane: python-pygments = 0.8.1-1.fc8 = /usr/bin/python ? python >= 2.3 (manual dependency not needed) python(abi) = 2.5 * %check is not present as there is no upstream test suite. I manually verified the above tests. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review