Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: msmtp - an SMTP client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243631 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pertusus@xxxxxxx Flag| |fedora-review+ ------- Additional Comments From pertusus@xxxxxxx 2007-06-30 04:37 EST ------- * rpmlint is silent * GPL, license included * follow naming and packaging guidelines * source match upstream ba5b61d5f7667d288f1cfadccfff8ac5 msmtp-1.4.12.tar.bz2 * sane provides * %files section right APPROVED 2 remarks: - info and man pages timestamps are not kept. The following should do the trick: make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' - linking is done by adding the library names to the command line instead of using -l. That's because gnulib/m4/lib-link.m4 is used instead of standard autoconf macros. I have read a bit the code, seems like upstream wants to use $libdir/libsomething.so and set rpath whatever the default path is. I don't really understand the implication of this choice. I guess that the result is right on Fedora in any case. The link command is: gcc -std=gnu99 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -o msmtp conf.o list.o msmtp.o net.o netrc.o smtp.o stream.o tools.o tls.o ../gnulib/libgnu.a /usr/lib/libgnutls.so /usr/lib/libgsasl.so /usr/lib/libidn.so -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review