Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtomcrypt - comprehensive, portable cryptographic toolkit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245432 ------- Additional Comments From jeremy@xxxxxxxxxxxxxxx 2007-06-30 02:21 EST ------- (In reply to comment #4) > Now that libtommath is done, I thought I'd take a look at this. However, I find > many rpmlint complaints like the following: > > W: libtomcrypt undefined-non-weak-symbol /usr/lib64/libtomcrypt.so.0.0.117 > mp_prime_is_prime > > It seems that this library isn't actually linked against libtommath even though > it uses functions from it heavily. I added > export EXTRALIBS="-ltommath" > to the %build section and that makes most of them go away, but there are still a > bunch in libtomcrypt_prof.so: > > W: libtomcrypt undefined-non-weak-symbol /usr/lib64/libtomcrypt_prof.so.0.0.117 > rc2_desc > > I'm not really sure what the _prof library is, however. Is it something we > really want to ship? I didn't get those W:'s when I ran rpmlint, but I also don't have a x86_64 machine. Let me know if the new SRPM causes the same complaints Your right, the _prof library is not necessary, and I've removed it from the RPM. I had the wrong -l flag in the spec so that fixes the -ltommath linkage failure. Also, I managed to get the make test && ./test to work so we have a %check now. new SPEC: http://jeremy.hinegardner.org/fedora/libtomcrypt/libtomcrypt.spec new SRPM: http://jeremy.hinegardner.org/fedora/libtomcrypt/libtomcrypt-1.17-4.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review