Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtommath - portable number theoretic multiple-precision integer library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245431 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-29 15:53 EST ------- Sorry for all the nitpicking; here's a full review: You usually shouldn't include the package name in the summary. It's a bit odd to see the buildrequires split like that, but it's not a real issue. Generally we like to see any available test suites run run if at all possible. The "test" and "mtest" makefile targets exist but I have no idea if they're useful at all for testing. I don't see that any of these are blockers. APPROVED Review: * source files match upstream: 8e397fc42a12f520ea50c29e477a8768a6f974af2470636f6f807141c13a240c ltm-0.41.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. ? summary starts with the package name. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text (grant to public domain) included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: libtommath-0.41-4.fc8.x86_64.rpm libtommath.so.0()(64bit) libtommath = 0.41-4.fc8 = /sbin/ldconfig libtommath.so.0()(64bit) libtommath-devel-0.41-4.fc8.x86_64.rpm libtommath-devel = 0.41-4.fc8 = libtommath = 0.41-4.fc8 libtommath.so.0()(64bit) * %check is not present. There are some test-related things in the tarball (the "test" and "mtest" makefile targets) but I have no idea how to run them. * shared libraries present; ldconfig called as necessary and unversioned .so files are in the -devel subpackage. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (ldconfig) * code, not content. * documentation is all in the -devel subpackage. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel subpackage. * no pkgconfig files (unfortunately; it would make the move of the include files easier) * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review