Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtommath - portable number theoretic multiple-precision integer library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245431 ------- Additional Comments From jeremy@xxxxxxxxxxxxxxx 2007-06-29 23:08 EST ------- (In reply to comment #6) > Sorry for all the nitpicking; here's a full review: > > You usually shouldn't include the package name in the summary. Fixed. > It's a bit odd to see the buildrequires split like that, but it's not a real issue. And here I thought I was being smart because all the tex stuff is only there to build the developer documentation. > Generally we like to see any available test suites run run if at all possible. > The "test" and "mtest" makefile targets exist but I have no idea if they're > useful at all for testing. I took a look, the test and mtest makefile targets both require the statically compiled libtommath.a. 'test' creates a program that is run with user interaction and 'mtest' creates a program that runs infinitely. I'm betting neither of those would be useful or appreciated by koji :-). > I don't see that any of these are blockers. > > APPROVED Thanks! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review