https://bugzilla.redhat.com/show_bug.cgi?id=1339004 --- Comment #2 from Emmanuel Seyman <emmanuel@xxxxxxxxx> --- (In reply to Petr Pisar from comment #1) > > FIX: The gettext_xs/Makefile.PL license comment is wrong. It should declare > `LGPLv2+'. I cannot find any `GPLv2+' declaration in the sources. Indeed. Fixed. > FIX: Build-require `perl-generators'. > FIX: Build-require `perl-devel' (gettext_xs/gettext_xs.xs:20). Fixed. > TODO: Do not build-require `perl(Carp)'. It's not used when running tests. > > TODO: You can replace the `-exec rm' command with `-delete' to avoid > executing `rm' in the %install section. Fixed. > FIX: Tests fails for me: > [...] > This is because the ./tests/03bind_textdomain_codeset_pp.t test expects > support de_AT locale. You have to build-require glibc-langpack-de. Wow, good catch. Fixed. > TODO: Report the old FSF address. Done. This is ticket #114731 on CPAN's RT: https://rt.cpan.org/Public/Bug/Display.html?id=114731 > TODO: You could correct the shell bang in the examples not to use > /usr/local/bin/perl. Done. I now also convert the non-UTF-8 files to UTF-8. > FIX: This new package must conflicts or obsoletes perl-libintl package. The > two clashes on files. I believe you need `Obsoletes: perl-libintl < 1.25'. I was convinced that a Provides was sufficient. Added. > TODO: List the optional run-time dependencies as Recommends or Suggests. Done. Spec URL: http://people.parinux.org/~seyman/fedora/perl-libintl-perl/perl-libintl-perl.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-libintl-perl/perl-libintl-perl-1.25-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx