https://bugzilla.redhat.com/show_bug.cgi?id=1339004 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-libintl-perl.spec.old 2016-05-24 00:12:27.000000000 +0200 +++ perl-libintl-perl.spec 2016-05-26 14:36:31.000000000 +0200 @@ -1,9 +1,9 @@ Summary: Internationalization library for Perl, compatible with gettext Name: perl-libintl-perl Version: 1.25 -Release: 1%{?dist} +Release: 2%{?dist} # gettext_xs/gettext_xs.pm: GPLv3+ -# gettext_xs/Makefile.PL: GPLv2+ +# gettext_xs/Makefile.PL: LGPLv2+ # lib/Locale/gettext_xs.pod: LGPLv2+ # lib/Locale/RecodeData.pm: GPLv3+ # lib/Locale/libintlFAQ.pod: LGPLv2+ @@ -13,12 +13,15 @@ Source: http://search.cpan.org/CPAN/authors/id/G/GU/GUIDO/libintl-perl-%{version}.tar.gz # this module was renamed in the f25 dev cycle Provides: perl-libintl = %{version}-%{release} +Obsoletes: perl-libintl < 1.25 BuildRequires: coreutils BuildRequires: findutils BuildRequires: gcc BuildRequires: make BuildRequires: perl +BuildRequires: perl-devel +BuildRequires: perl-generators BuildRequires: perl(Config) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(File::Find) @@ -28,7 +31,6 @@ # Run-time: BuildRequires: perl(base) BuildRequires: perl(bytes) -BuildRequires: perl(Carp) BuildRequires: perl(constant) BuildRequires: perl(Cwd) BuildRequires: perl(DynaLoader) @@ -44,6 +46,8 @@ BuildRequires: perl(File::ShareDir) BuildRequires: perl(I18N::Langinfo) # Tests: +# Needed for tests/03bind_textdomain_codeset_pp.t +BuildRequires: glibc-langpack-de BuildRequires: perl(File::Basename) BuildRequires: perl(Test) BuildRequires: perl(Test::Harness) @@ -51,6 +55,8 @@ Requires: perl(Carp) Requires: perl(Encode::Alias) Requires: perl(POSIX) +Recommends: perl(File::ShareDir) +Recommends: perl(I18N::Langinfo) %{?perl_default_filter} @@ -65,6 +71,14 @@ find -type f -exec chmod -x {} \; find lib/Locale gettext_xs \( -name '*.pm' -o -name '*.pod' \) \ -exec sed -i -e '/^#! \/bin\/false/d' {} \; +# Fix rpmlint errors and warnings +cd sample/simplecal +sed -i -e '1i#!%{__perl}' bin/simplecal.pl Makefile.PL +for file in po/*.po; do + iconv -f ISO-8859-1 -t UTF-8 -o $file.new $file && \ + mv $file.new $file +done + %build perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}" @@ -73,7 +87,7 @@ %install make pure_install DESTDIR=%{buildroot} find %{buildroot} -type f \( -name .packlist -o \ - -name '*.bs' -size 0 \) -exec rm -f {} ';' + -name '*.bs' -size 0 \) -delete %{_fixperms} %{buildroot} %check @@ -88,6 +102,9 @@ %{_mandir}/man?/* %changelog +* Wed May 25 2016 Emmanuel Seyman <emmanuel@xxxxxxxxx> - 1.25-2 +- Take into account the re-review comments (#1339004) + * Sat May 21 2016 Emmanuel Seyman <emmanuel@xxxxxxxxx> - 1.25-1 - Update package to 1.25-1 - Rename package to perl-libintl-perl, the module's name on CPAN All the issues are fixed. TODO: Build-require `glibc-common' for iconv tool in %prep section. $ rpmlint perl-libintl-perl.spec ../SRPMS/perl-libintl-perl-1.25-2.fc25.src.rpm ../RPMS/x86_64/perl-libintl-perl-* perl-libintl-perl.src: W: spelling-error Summary(en_US) gettext -> get text, get-text, Georgette perl-libintl-perl.src: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: W: spelling-error Summary(en_US) gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: E: incorrect-fsf-address /usr/share/perl5/vendor_perl/Locale/gettext_xs.pod perl-libintl-perl.x86_64: E: incorrect-fsf-address /usr/share/perl5/vendor_perl/Locale/libintlFAQ.pod perl-libintl-perl.x86_64: W: manifest-in-perl-module /usr/share/doc/perl-libintl-perl/sample/simplecal/MANIFEST 3 packages and 1 specfiles checked; 2 errors, 5 warnings. rpmlint is Ok. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=14261048). Ok. Please consider fixing the `TODO' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx