https://bugzilla.redhat.com/show_bug.cgi?id=1339004 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive (SHA-256: a597e128742e1c1c973a5e968626ef55eb270e8ecde793333c7a7247895f2431) is original. Ok. Summary and description verified from the old perl-libintl.spec. Ok. FIX: The gettext_xs/Makefile.PL license comment is wrong. It should declare `LGPLv2+'. I cannot find any `GPLv2+' declaration in the sources. The license tag is Ok. FIX: Build-require `perl-generators'. FIX: Build-require `perl-devel' (gettext_xs/gettext_xs.xs:20). version module is nowhere used. Ok. MyInstall.pm is executed during the build. Ok. TODO: Do not build-require `perl(Carp)'. It's not used when running tests. TODO: You can replace the `-exec rm' command with `-delete' to avoid executing `rm' in the %install section. FIX: Tests fails for me: ./tests/03bind_textdomain_codeset_pp.t .. 1/14 # Test 8 got: "March" (./tests/03bind_textdomain_codeset_pp.t at line 74) # Expected: "M\xE4rz" # ./tests/03bind_textdomain_codeset_pp.t line 74 is: ok gettext ('March'), 'M�rz'; ./tests/03bind_textdomain_codeset_pp.t .. Failed 1/14 subtests (less 3 skipped subtests: 10 okay) [...] Test Summary Report ------------------- ./tests/03bind_textdomain_codeset_pp.t (Wstat: 0 Tests: 14 Failed: 1) Failed test: 8 ./tests/03dcgettext_pp.t (Wstat: 0 Tests: 11 Failed: 2) Failed tests: 5, 9 ./tests/03dgettext_pp.t (Wstat: 0 Tests: 11 Failed: 2) Failed tests: 5, 9 ./tests/03gettext_pp.t (Wstat: 0 Tests: 8 Failed: 1) Failed test: 5 ./tests/03ngettext_pp.t (Wstat: 0 Tests: 88 Failed: 10) Failed tests: 24-33 ./tests/03pgettext_pp.t (Wstat: 0 Tests: 8 Failed: 3) Failed tests: 5-7 This is because the ./tests/03bind_textdomain_codeset_pp.t test expects support de_AT locale. You have to build-require glibc-langpack-de. $ rpmlint perl-libintl-perl.spec ../SRPMS/perl-libintl-perl-1.25-1.fc25.src.rpm ../RPMS/x86_64/perl-libintl-perl-* perl-libintl-perl.src: W: spelling-error Summary(en_US) gettext -> get text, get-text, Georgette perl-libintl-perl.src: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: W: spelling-error Summary(en_US) gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: W: spelling-error %description -l en_US gettext -> get text, get-text, Georgette perl-libintl-perl.x86_64: W: manifest-in-perl-module /usr/share/doc/perl-libintl-perl/sample/simplecal/MANIFEST perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/pt.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/ru.po perl-libintl-perl.x86_64: E: wrong-script-interpreter /usr/share/doc/perl-libintl-perl/sample/simplecal/Makefile.PL /usr/local/bin/perl perl-libintl-perl.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-libintl-perl/sample/simplecal/Makefile.PL perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/fr.po perl-libintl-perl.x86_64: E: incorrect-fsf-address /usr/share/perl5/vendor_perl/Locale/libintlFAQ.pod perl-libintl-perl.x86_64: E: wrong-script-interpreter /usr/share/doc/perl-libintl-perl/sample/simplecal/bin/simplecal.pl /usr/local/bin/perl perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/pt_BR.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/ar_SA.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/it.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/de_AT.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/ga.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/ar.po perl-libintl-perl.x86_64: W: file-not-utf8 /usr/share/doc/perl-libintl-perl/sample/simplecal/po/de.po perl-libintl-perl.x86_64: E: incorrect-fsf-address /usr/share/perl5/vendor_perl/Locale/gettext_xs.pod 3 packages and 1 specfiles checked; 5 errors, 15 warnings. rpmlint is Ok. TODO: Report the old FSF address. TODO: You could correct the shell bang in the examples not to use /usr/local/bin/perl. File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-libintl-perl-1.25-1.fc25.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libperl.so.5.24()(64bit) 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(:VERSION) >= 5.4.0 1 perl(base) 1 perl(bytes) 1 perl(Carp) 1 perl(constant) 1 perl(Cwd) 1 perl(DynaLoader) 1 perl(Encode) 1 perl(Encode::Alias) 1 perl(Exporter) 1 perl(File::Spec) 1 perl(integer) 1 perl(IO::Handle) 1 perl(locale) 1 perl(Locale::gettext_pp) 1 perl(Locale::Messages) 1 perl(Locale::Recode::_Conversions) 1 perl(Locale::RecodeData) 1 perl(POSIX) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-libintl-perl-1.25-1.fc25.x86_64.rpm Binary dependencies resolvable. Ok. FIX: This new package must conflicts or obsoletes perl-libintl package. The two clashes on files. I believe you need `Obsoletes: perl-libintl < 1.25'. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=14244533). Ok. TODO: List the optional run-time dependencies as Recommends or Suggests. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx