[Bug 1327989] Review Request: python-jupyter-client - Jupyter protocol implementation and client libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1327989



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Created attachment 1148304
  --> https://bugzilla.redhat.com/attachment.cgi?id=1148304&action=edit
patch to fix docs generation

Would be better for py2 subpackage to require python2-jupyter-core, not
python-jupyter-core.

- python-pyzmq → python-zmq
- python3-pyzmq → python3-zmq
- python-sphinxcontrib-napoleon and everything in Requires for python2 should
be in BuildRequires
- no need for python3-sphinx (or alternatively python3-sphinx could be used
instead of python2 sphinx)

+ package name is OK
+ license is acceptable (BSD)
+ license file is present, %license is used
+ latest version
+ builds and installs OK
- provides/requires look sane (see above)
+ %python_provide is used
+ no %check, but upstream does not provide tests

Please see attached patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]