https://bugzilla.redhat.com/show_bug.cgi?id=1327989 --- Comment #4 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > Created attachment 1148304 [details] > patch to fix docs generation > > Would be better for py2 subpackage to require python2-jupyter-core, not > python-jupyter-core. > > - python-pyzmq → python-zmq > - python3-pyzmq → python3-zmq > - python-sphinxcontrib-napoleon and everything in Requires for python2 > should be in BuildRequires Thanks for the patch! > - no need for python3-sphinx (or alternatively python3-sphinx could be used > instead of python2 sphinx) I use python-sphinx now, which should always provide an /usr/bin/sphinx-build (either python2 or python3). > + package name is OK > + license is acceptable (BSD) > + license file is present, %license is used > + latest version > + builds and installs OK > - provides/requires look sane (see above) > + %python_provide is used > + no %check, but upstream does not provide tests > > Please see attached patch. Changelog: - Fix docs generation - Require python2- instead python- where possible Spec URL: https://tomspur.fedorapeople.org/review/python-jupyter-client/python-jupyter-client.spec SRPM URL: https://tomspur.fedorapeople.org/review/python-jupyter-client/python-jupyter-client-4.2.2-3.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx