https://bugzilla.redhat.com/show_bug.cgi?id=988667 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #32 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- So... the changelog. Please note that it's not something to fix, just a comment for the future: The last entry is OK, the first entry is OK, the ones in between are pretty much useless :) Even during review, before the package is offically built, it's recommended to add changelog entries (like the last one) to make the life of the reviewer easier. But for this to be useful, those entries need to say what the changes actually were. No sense in installing ChangeLog file, it's empty. Here we go: + package name is OK + latest version + license is acceptable (GPLv2+) + license file is present, %license is used + builds and installs OK + provides/requires look sane + scriplets are OK Package is APPROVED. -- You also need to be sponsored into the packagers group. I can do that. Please do two or three reviews of packages from http://fedoraproject.org/PackageReviewStatus/NEW.html, and paste the links here. It's best to start with the output of fedora-review and going over the checklist it produces, and also rpmlint (although it has many false positives, so don't take it too seriously). -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx