[Bug 1325763] Review Request: perl-Test-Requires-Git - Check your test requirements against the available version of Git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1325763

Jan Pazdziora <jpazdziora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jpazdziora@xxxxxxxxxx



--- Comment #2 from Jan Pazdziora <jpazdziora@xxxxxxxxxx> ---
Thank you for the review.

The .spec file at https://adelton.fedorapeople.org/perl-Test-Requires-Git.spec
was updated with the patch below, hopefully addressing all FIX and TODO items.

--- perl-Test-Requires-Git.spec.take1    2016-04-11 08:50:25.734171589 +0200
+++ perl-Test-Requires-Git.spec    2016-04-18 08:24:02.387846065 +0200
@@ -10,6 +10,8 @@

 BuildRequires:  findutils
 BuildRequires:  make
+BuildRequires:  perl
+BuildRequires:  perl(base)
 BuildRequires:  perl(Carp)
 BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(File::Spec)
@@ -20,8 +22,10 @@
 BuildRequires:  perl(Test::Builder::Module)
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(warnings)
+BuildRequires:  perl-generators
+
+%global __requires_exclude ^perl\\(Git::Version::Compare\\)$
 Requires:       perl(Git::Version::Compare) >= 1.001
-Requires:       perl(Test::Builder::Module)
 Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))

 %description

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]