[Bug 1325763] Review Request: perl-Test-Requires-Git - Check your test requirements against the available version of Git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1325763

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> ---
> FIX: Build-require perl (perl-Test-Requires-Git.spec:35).
+BuildRequires:  perl
Ok.

> TODO: Build-require perl-generators.
+BuildRequires:  perl-generators
Ok.

> FIX: Build-require perl(base) (lib/Test/Requires/Git.pm:9).
+BuildRequires:  perl(base)
Ok.

$ rpmlint perl-Test-Requires-Git.spec
../SRPMS/perl-Test-Requires-Git-1.005-1.fc25.src.rpm
../RPMS/noarch/perl-Test-Requires-Git-1.005-1.fc25.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

> TODO: Do not require perl(Test::Builder::Module) explicitly.
> TODO: Filter unversioned perl(Git::Version::Compare) from requires.

$ rpm -q --requires -p
../RPMS/noarch/perl-Test-Requires-Git-1.005-1.fc25.noarch.rpm | sort -f | uniq
-c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(base)
      1 perl(Carp)
      1 perl(Git::Version::Compare) >= 1.001
      1 perl(strict)
      1 perl(Test::Builder::Module)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

Package build in F25
(http://koji.fedoraproject.org/koji/taskinfo?taskID=13696414). Ok.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]