https://bugzilla.redhat.com/show_bug.cgi?id=1325763 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: f0d8e0f77d12122cf884bf48f0a65883eb208f8222a58b52d2e720d379f675ed). Ok. Summary verified from lib/Test/Requires/Git.pm. Ok. Description verified from lib/Test/Requires/Git.pm. Ok. License verified from README, lib/Test/Requires/Git.pm, LICENSE. Ok. No XS code, noarch BuildArch is Ok. FIX: Build-require perl (perl-Test-Requires-Git.spec:35). TODO: Build-require perl-generators. (This package delivers scripts that generate dependencies for a built package. The perl-generators will be removed from minimal build root in the near future.) FIX: Build-require perl(base) (lib/Test/Requires/Git.pm:9). Test::Pod::Coverage not used. Ok. Pod::Coverage::TrustPod not used Ok. Test::CPAN::Meta not used. Ok. Test::Pod not used. Ok. CPAN::Meta not useful Ok. CPAN::Meta::Prereqs not useful Ok. I believe this package does not have to run-require git. Ok. All tests pass. Ok. $ rpmlint perl-Test-Requires-Git.spec ../SRPMS/perl-Test-Requires-Git-1.005-1.fc25.src.rpm ../RPMS/noarch/perl-Test-Requires-Git-1.005-1.fc25.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Test-Requires-Git-1.005-1.fc25.noarch.rpm drwxr-xr-x 2 root root 0 Apr 11 17:24 /usr/share/doc/perl-Test-Requires-Git -rw-r--r-- 1 root root 1077 Apr 2 01:09 /usr/share/doc/perl-Test-Requires-Git/Changes -rw-r--r-- 1 root root 763 Apr 2 01:09 /usr/share/doc/perl-Test-Requires-Git/README drwxr-xr-x 2 root root 0 Apr 11 17:24 /usr/share/licenses/perl-Test-Requires-Git -rw-r--r-- 1 root root 18379 Apr 2 01:09 /usr/share/licenses/perl-Test-Requires-Git/LICENSE -rw-r--r-- 1 root root 2661 Apr 11 17:24 /usr/share/man/man3/Test::Requires::Git.3pm.gz drwxr-xr-x 2 root root 0 Apr 11 17:24 /usr/share/perl5/vendor_perl/Test drwxr-xr-x 2 root root 0 Apr 11 17:24 /usr/share/perl5/vendor_perl/Test/Requires -rw-r--r-- 1 root root 7943 Apr 2 01:09 /usr/share/perl5/vendor_perl/Test/Requires/Git.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Test-Requires-Git-1.005-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.22.1) 1 perl(base) 1 perl(Carp) 1 perl(Git::Version::Compare) 1 perl(Git::Version::Compare) >= 1.001 1 perl(strict) 2 perl(Test::Builder::Module) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Do not require perl(Test::Builder::Module) explicitly. TODO: Filter unversioned perl(Git::Version::Compare) from requires. $ rpm -q --provides -p ../RPMS/noarch/perl-Test-Requires-Git-1.005-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(Test::Requires::Git) = 1.005 1 perl-Test-Requires-Git = 1.005-1.fc25 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Test-Requires-Git-1.005-1.fc25.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=13626172). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items and provide a new package. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx