https://bugzilla.redhat.com/show_bug.cgi?id=1323181 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1221204 Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Original review in #1221204. +Provides: python-docker-scripts = %{version}-%{release} +Obsoletes: python-docker-scripts <= 1.0.0-0.2.rc2 Looks correct. See https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services for a nicer way to specify Source URL that gives an archive with a better name. Why do you provide both /usr/bin/docker-squash3 and /usr/bin/docker-squash? Do they provide different functionality? If not, only one should be provided. If both implementations are equivalent, implementation in python3 is preferred [https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin]. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx