[Bug 1324233] Review Request: python-toolz - A functional standard library for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1324233

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Great that you're packaging that, it's a very nice library. I'm rather
surprised that it's not in Fedora yet.

There's a strange indentation in " contemporary functional languages".

Can you add %global _description, and use it in the three places? The
description is quite long.

+ license is acceptable (BSD)
+ license file is present, %license is used
+ builds and installs OK
+ requires and provides look sane
+ %python_provide is used
+ standard python template is used
+ no scriptlets present or necessary
+ rpmlint: only bogus spelling errors and missing documentation warnings

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]