https://bugzilla.redhat.com/show_bug.cgi?id=1299139 --- Comment #25 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- -Werror strikes again: Testing swap qsort_r... ((gcc -Werror -o os-features-test-swap-qsort \ -g -Wall -ffinite-math-only -fno-signaling-nans -pthread -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -O3 -fomit-frame-pointer -DNDEBUG -fpic -Winline -I../include -I../include/astrometry -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DAN_GIT_REVISION='"0.67"' -DAN_GIT_DATE='"Mon_Jan_25_11:20:00_2016_-0500"' -DAN_GIT_URL='"https://github.com/dstndstn/astrometry.net"' -I../util -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/libpng16 -DWCSLIB_EXISTS -I../include -I../include/astrometry -I/usr/include/wcslib -I../include -I../include/astrometry -I/usr/include/wcslib -I. -DTEST_SWAP_QSORT_R os-features-test.c -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -g -Wall -ffinite-math-only -fno-signaling-nans -pthread -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -O3 -fomit-frame-pointer -DNDEBUG -fpic -Winline >> os-features.log && \ ./os-features-test-swap-qsort >> os-features.log && \ echo "#define NEED_SWAP_QSORT_R 0") \ || echo "#define NEED_SWAP_QSORT_R 1") >> ../include/astrometry/os-features-config.h.tmp os-features-test.c: In function 'main': os-features-test.c:68:36: error: passing argument 4 of 'qsort_r' from incompatible pointer type [-Werror=incompatible-pointer-types] qsort_r(array, N, sizeof(int), &mythunk, sortfunc); ^ In file included from os-features-test.c:5:0: /usr/include/stdlib.h:767:13: note: expected '__compar_d_fn_t {aka int (*)(const void *, const void *, void *)}' but argument is of type 'int *' extern void qsort_r (void *__base, size_t __nmemb, size_t __size, ^~~~~~~ cc1: all warnings being treated as errors There's also a bunch of interesting warnings: kdtree_internal.c: In function 'kdtree_build_2_fff': kdtree_internal.c:2247:2: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation] kd->lr[0] = N - 1; ^~ kdtree_internal.c:2243:5: note: ...this 'if' clause, but it is not if (options & KD_BUILD_LINEAR_LR) ^~ Might be worth looking into. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review