https://bugzilla.redhat.com/show_bug.cgi?id=1318368 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-IRI-0.004-1.fc25.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.22.1) 1 perl(:VERSION) >= 5.14.0 1 perl(Data::Dumper) 1 perl(Moo) 1 perl(MooX::HandlesVia) 1 perl(Scalar::Util) 1 perl(Types::Standard) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-IRI-0.004-1.fc25.noarch.rpm | sort | uniq -c 1 perl(IRI) = 0.004 1 perl-IRI = 0.004-1.fc25 Binary provides are Ok. $ rpmlint ./perl-IRI* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok BuildRequires are ok FIX: Please add 'coreutils' - specfile line 45 TODO: perl(strict) and perl(warnings) could be part of first group of BR, because they are used in Makefile.PL FIX: Remove '%clean' from spec file line 60 Please correct all 'FIX' issues and consider fixing 'TODO' items. Otherwise package is good. Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review