https://bugzilla.redhat.com/show_bug.cgi?id=1317939 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks|177841 (FE-NEEDSPONSOR) | Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Permissions will be wrong on the unit file, you should add -m644. (/usr/bin/install is stupid). Also, if you use -D, you can get rid of the separate mkdir... It's often a bit nicer this way. Use 'cp -a', to preserve timestamps on files. 'make faup1090' → %make_build faup1090 to have the -j flag. %description is much better. But maybe you could add another sentence like "It provides a daemon that serves ...". -- I can sponsor you into the packagers group. Please do two or three reviews of packages from http://fedoraproject.org/PackageReviewStatus/NEW.html, and paste the links here. Please pick packages that are in the area you are interested in, and that other people haven't picked up, so that you can finalize the review after you get the packager privs. Also don't pick things that are overly complicated, we don't want to get bogged down in details. Running fedora-review is a good first step, but please note that the automatically generated template needs to be filled in in various places, and trimmed in others. Not everything the tools say is always correct. Sometimes they are outdated, sometimes they are plain wrong. It's always best to link to the relevant part of the guidelines. If you have any questions or issues, I'd always be happy to help (zbyszek at in waw pl, zbyszek on #fedora-devel). Also, you should update your bugzilla mail to match your FAS info, or the other way around. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review