https://bugzilla.redhat.com/show_bug.cgi?id=1270357 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Some more macros would simplify things a bit: cd obj-%{gcc_target_platform} make DESTDIR=%{buildroot} install ... ↓ %make_install -C obj-%{gcc_target_platform} %autosetup -p1 %license for COPYING*. Why not parallelized make? E.g. %make_build ? Summary should be more concrete: C and C++ compilers for nacl (unless there's something more, but I don't think). I think the Summary should also have some small explanation what nacl is (just in case somebody is looking for a normal compiler and they see this package). The %description seems outdated: "The gcc package contains the GNU Compiler Collection version 4.4.3. You'll need this package in order to compile C code." No %check? There seems to be many test cases... I don't know how feasible it would be to run them. This all looks very reasonable. Apart from some cleanups I don't see anything to change. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review