[Bug 1318059] Review Request: morituri - Accurate CD ripper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1318059

Antonio Trande <anto.trande@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anto.trande@xxxxxxxxx



--- Comment #2 from Antonio Trande <anto.trande@xxxxxxxxx> ---
Hi Stefan,

- set configure to be more verbose;
- set configure PYTHON variable;
- Make command does not use %{?_smp_mflags}
http://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make ;

- please, use %{buildroot} or $RPM_BUILD_ROOT, not both;

- %defattr(-,root,root) is not need;

- use %license for COPYING file
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

- use %{python2_sitelib} macro
http://fedoraproject.org/wiki/Packaging:Python#Macros

- %changelog is not correct
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]