[Bug 1318059] Review Request: morituri - Accurate CD ripper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1318059



--- Comment #3 from Stefan Nuxoll <stefan@xxxxxxxxxxxxx> ---
Updated spec file:

https://snuxoll.fedorapeople.org/packages/morituri.spec


New koji scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=13368364

> - set configure to be more verbose

I am now passing --verbose to the configure script, although there is no
additional output

> - set configure PYTHON variable;

Done, since this project is python2 only I am using the %{__python2} macro,
thanks for catching this.

> - Make command does not use %{?_smp_mflags}

Done

> - please, use %{buildroot} or $RPM_BUILD_ROOT, not both;

I am using %{buildroot} only now

> - use %license for COPYING file

Done

> - use %{python2_sitelib} macro

Done

> - %changelog is not correct

I assume you are referencing the missing ver-rel tag at the end of the
changelog line, this has been corrected. If there is something else missing
please give me more details.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]