[Bug 1127967] Review Request: python-releases - A Sphinx extension for changelog manipulation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1127967



--- Comment #12 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> ---
* Spec is clean and follows the guidelines
* Builds successfully on rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=13366034
* Builds successfully on F23:
koji.fedoraproject.org/koji/taskinfo?taskID=13366113
* Is the latest release

! The doc included can likely be built with sphinx and we could put it in a
-doc package (regardless of the python version)
! Tests are included in the tarball but not ran in the spec file and there are
no explanation on why that is

On both py2 and py3, I tried just testing it a little to see if it behaved
fine. This is likely invalid code but at least it's an upstream bug:

>>> import releases
>>> releases.Release()
Traceback (most recent call last):
  File "<input>", line 1, in <module>
    releases.Release()
  File "/usr/lib/python3.4/site-packages/releases/models.py", line 53, in
__repr__
    return '<release {0}>'.format(self.number)
  File "/usr/lib/python3.4/site-packages/releases/models.py", line 50, in
number
    return self['number']
  File "/usr/lib/python3.4/site-packages/docutils/nodes.py", line 567, in
__getitem__
    return self.attributes[key]
KeyError: 'number'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]