https://bugzilla.redhat.com/show_bug.cgi?id=1317392 Jan Pazdziora <jpazdziora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpazdziora@xxxxxxxxxx --- Comment #2 from Jan Pazdziora <jpazdziora@xxxxxxxxxx> --- Thank you very much. The .spec at https://adelton.fedorapeople.org/perl-Git-Version-Compare.spec was updated with the patch below. I hope I managed to incorporate all FIXes and TODOs, except the PERL_INSTALL_ROOT one (which seems a bit more expressive than DESTDIR). By the way, should we track the changes that were needed as requirements for cpanspec? --- perl-Git-Version-Compare.spec.take1 2016-03-14 09:16:36.810425824 +0100 +++ perl-Git-Version-Compare.spec 2016-03-14 13:58:30.492172823 +0100 @@ -8,6 +8,9 @@ Source0: http://www.cpan.org/modules/by-module/Git/Git-Version-Compare-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch + +BuildRequires: findutils +BuildRequires: make BuildRequires: perl >= 0:5.006 BuildRequires: perl(Carp) BuildRequires: perl(Exporter) @@ -15,11 +18,11 @@ BuildRequires: perl(File::Spec) BuildRequires: perl(namespace::clean) BuildRequires: perl(Scalar::Util) +BuildRequires: perl(strict) BuildRequires: perl(Test::More) -Requires: perl(Carp) -Requires: perl(Exporter) -Requires: perl(namespace::clean) -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +BuildRequires: perl(warnings) + +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) %description Git::Version::Compare contains a selection of subroutines that make dealing @@ -29,7 +32,7 @@ %setup -q -n Git-Version-Compare-%{version} %build -%{__perl} Makefile.PL INSTALLDIRS=vendor +perl Makefile.PL INSTALLDIRS=vendor make %{?_smp_mflags} %install @@ -38,19 +41,15 @@ make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; -find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; %{_fixperms} $RPM_BUILD_ROOT/* %check make test -%clean -rm -rf $RPM_BUILD_ROOT - %files -%defattr(-,root,root,-) -%doc Changes dist.ini LICENSE META.json README +%license LICENSE +%doc Changes README %{perl_vendorlib}/* %{_mandir}/man3/* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review