https://bugzilla.redhat.com/show_bug.cgi?id=1317392 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: 1ffb4450b6dc445a705bfb174a29827169bf1f7094ae2cb88e94e54bdf95c7d1). Ok. Summary verified from lib/Git/Version/Compare.pm. Ok. Description verified from lib/Git/Version/Compare.pm. Ok. License verified from lib/Git/Version/Compare.pm, README, LICENSE, Makefile.PL. Ok. No XS code, noarch BuildArch is Ok. TODO: Remove BuildRoot defintion and cleaning. This is done automatically in Fedora. TODO: You can replace %__perl macros with plain perl command. TODO: You can replace PERL_INSTALL_ROOT argument with DESTDIR argument to make it more similar to autootols. TODO: You can remove command for deleting empty directories in the %install section. Current ExtUtils::MakeMaker does not create empty directories. TODO: Remove %deffattr macro, this is implicit in Fedora. FIX: Package LICENSE file using %license macro. Not using %doc macro. TODO: Do not package dist.ini and META.json files. These are instructions for installation, not for using. FIX: Build-require `make' (perl-Git-Version-Compare.spec:33). FIX: Build-require `findutils (perl-Git-Version-Compare.spec:40). FIX: Build-require `perl(strict)' (Makefile.PL:2). FIX: Build-require `perl(warnings)' (Makefile.PL:3). Test::Pod::Coverage not used. Ok. Pod::Coverage::TrustPod not used. Ok. Test::CPAN::Meta not used. Ok. Test::Pod not used. Ok. All tests pass. Ok. $ rpmlint perl-Git-Version-Compare.spec ../SRPMS/perl-Git-Version-Compare-1.001-1.fc25.src.rpm ../RPMS/noarch/perl-Git-Version-Compare-1.001-1.fc25.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Git-Version-Compare-1.001-1.fc25.noarch.rpm drwxr-xr-x 2 root root 0 Mar 14 13:22 /usr/share/doc/perl-Git-Version-Compare -rw-r--r-- 1 root root 571 Feb 20 12:02 /usr/share/doc/perl-Git-Version-Compare/Changes -rw-r--r-- 1 root root 18379 Feb 20 12:02 /usr/share/doc/perl-Git-Version-Compare/LICENSE -rw-r--r-- 1 root root 1874 Feb 20 12:02 /usr/share/doc/perl-Git-Version-Compare/META.json -rw-r--r-- 1 root root 960 Feb 20 12:02 /usr/share/doc/perl-Git-Version-Compare/README -rw-r--r-- 1 root root 1065 Feb 20 12:02 /usr/share/doc/perl-Git-Version-Compare/dist.ini -rw-r--r-- 1 root root 3311 Mar 14 13:22 /usr/share/man/man3/Git::Version::Compare.3pm.gz drwxr-xr-x 2 root root 0 Mar 14 13:22 /usr/share/perl5/vendor_perl/Git drwxr-xr-x 2 root root 0 Mar 14 13:22 /usr/share/perl5/vendor_perl/Git/Version -rw-r--r-- 1 root root 9153 Feb 20 12:02 /usr/share/perl5/vendor_perl/Git/Version/Compare.pm FIX: Package LICENSE file using %license macro. Not using %doc macro. $ rpm -q --requires -p ../RPMS/noarch/perl-Git-Version-Compare-1.001-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.22.1) 2 perl(Carp) 2 perl(Exporter) 2 perl(namespace::clean) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Do not run-require `perl(Carp)', `perl(Exporter)', and `perl(namespace::clean)' explicitly. The are found automatically. $ rpm -q --provides -p ../RPMS/noarch/perl-Git-Version-Compare-1.001-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(Git::Version::Compare) = 1.001 1 perl-Git-Version-Compare = 1.001-1.fc25 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Git-Version-Compare-1.001-1.fc25.noarch.rpm Binary dependencies resolvable. Ok. Package build in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=13343461). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review