https://bugzilla.redhat.com/show_bug.cgi?id=1317392 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- > By the way, should we track the changes that were needed as requirements > for cpanspec? We know that cpanspec generates old spec files. We contacted upstream many times and he always claimed he will fix it soon. Documenting the required/recommended changes could be helpful. Maybe this page <https://fedoraproject.org/wiki/Perl/Tips> could host it. > TODO: Remove BuildRoot defintion and cleaning. This is done automatically > in Fedora. Partially addressed. You can still remove the first line in the %install section and the `BuildRoot:' tag on line 9. > TODO: You can replace %__perl macros with plain perl command. Ok. > TODO: You can replace PERL_INSTALL_ROOT argument with DESTDIR argument to make it > more similar to autootols. Not addressed. Ok. > TODO: You can remove command for deleting empty directories in the %install section. > Current ExtUtils::MakeMaker does not create empty directories. Ok. > TODO: Remove %deffattr macro, this is implicit in Fedora. Ok. > FIX: Package LICENSE file using %license macro. Not using %doc macro. Ok. > TODO: Do not package dist.ini and META.json files. These are instructions for > installation, not for using. Ok. > FIX: Build-require `make' (perl-Git-Version-Compare.spec:33). Ok. > FIX: Build-require `findutils (perl-Git-Version-Compare.spec:40). Ok. > FIX: Build-require `perl(strict)' (Makefile.PL:2). Ok. > FIX: Build-require `perl(warnings)' (Makefile.PL:3). Ok. FIX: Build-require `coreutils' (perl-Git-Version-Compare.spec:43) or replace the "-exec rm -f {} \;" with "-delete" argument. $ rpmlint perl-Git-Version-Compare.spec ../SRPMS/perl-Git-Version-Compare-1.001-1.fc25.src.rpm ../RPMS/noarch/perl-Git-Version-Compare-1.001-1.fc25.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. > TODO: Do not run-require `perl(Carp)', `perl(Exporter)', and > `perl(namespace::clean)' explicitly. The are found automatically. $ rpm -q --requires -p ../RPMS/noarch/perl-Git-Version-Compare-1.001-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.22.1) 1 perl(Carp) 1 perl(Exporter) 1 perl(namespace::clean) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=13344091). Ok. Please correct the `FIX' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review