[Bug 1309792] Review Request: fedora-motd - Generate dynamic MOTD for Fedora

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1309792



--- Comment #5 from Ratnadeep Debnath <rtnpro@xxxxxxxxx> ---
(In reply to Jared Smith from comment #4)
> Just two additional comments:
> 
> 1) There's no reason to list out the following two files, since you've
> already specified the directory which contains them:
> 
> %{_sysconfdir}/motdgen.d/01-uptime.sh
> %{_sysconfdir}/motdgen.d/02-updateinfo.sh

Removed them!

> 2) Do you really want those files marked as %config(noreplace)?  That means
> if you push out an updated version of those scripts, that the original file
> will stay in place and that the new version will be pushed out with a
> .rpmnew extension.  Since these really aren't config files and are scripts,
> I'm assuming that you *would* want them replaced in the case of an upgrade.

Since most of my config files are actually scripts, I have removed
"%config(noreplace)" for them.

Let me know if I need to fix something else.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]