https://bugzilla.redhat.com/show_bug.cgi?id=1309792 Jared Smith <jsmith.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jsmith.fedora@gma | |il.com) | --- Comment #4 from Jared Smith <jsmith.fedora@xxxxxxxxx> --- Just two additional comments: 1) There's no reason to list out the following two files, since you've already specified the directory which contains them: %{_sysconfdir}/motdgen.d/01-uptime.sh %{_sysconfdir}/motdgen.d/02-updateinfo.sh 2) Do you really want those files marked as %config(noreplace)? That means if you push out an updated version of those scripts, that the original file will stay in place and that the new version will be pushed out with a .rpmnew extension. Since these really aren't config files and are scripts, I'm assuming that you *would* want them replaced in the case of an upgrade. Please address these two issues, and I'll gladly approve the package. Also, I should be in IRC most of the day today if you want to discuss. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review