[Bug 1309792] Review Request: fedora-motd - Generate dynamic MOTD for Fedora

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1309792

Ratnadeep Debnath <rtnpro@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(jsmith.fedora@gma
                   |                            |il.com)



--- Comment #3 from Ratnadeep Debnath <rtnpro@xxxxxxxxx> ---
Hey Jared,

(In reply to Jared Smith from comment #2)
>  - Please add /etc/motdgen.d to the %files section, so that this package owns
>    that directory
Fixed!

>  - Add dependencies for 'pam' and 'crontabs' and 'setup' if you're going to
>    use the /etc/pam.d, etc/cron.daily, and /etc/profile.d directories
Fixed!

>  - /etc/cron.daily/motdgen-cache-updateinfo is marked as a config file, but
> is
>    executable
Most of the cron scripts are marked as executable. I asked @threebean about
this, and he suggested to ignore this lint error.

I have pushed the updated SPEC and SRPM file at:
Spec URL: https://rtnpro.fedorapeople.org/Packages/SPECS/fedora-motd.spec
SRPM URL:
https://rtnpro.fedorapeople.org/Packages/SRPMS/fedora-motd-0.1-1.fc22.src.rpm

Let me know what you think.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]