https://bugzilla.redhat.com/show_bug.cgi?id=1311086 --- Comment #4 from Fabio Alessandro Locati <fabio@xxxxxxxxx> --- (In reply to James Hogarth from comment #3) > (In reply to Germano Massullo from comment #1) > > Could you please GPG sign the src.rpm file? > > Thank you > > I'm curious - why ask this? So far as I recall no such requirement to do so > has been placed on package reviews before (and I don't recall any changes in > guidelines to add this). > > In addition the fedora-review tool compares %source upstream to that in the > SRPM anyway ... As far as I know there is no such requirement, but Germano asked and since it's very easy and fast to do so, I just did it. > A quick test with fedora-review reveals a failure in %check right now that > needs correcting for the review request to proceed: > > ====================================================================== > ERROR: setUpClass (tests.integration.test_s3transfer.TestS3Transfers) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File > "/builddir/build/BUILD/s3transfer-0.0.1/tests/integration/test_s3transfer. > py", line 118, in setUpClass > CreateBucketConfiguration={'LocationConstraint': cls.region}) > File "/usr/lib/python3.5/site-packages/botocore/client.py", line 301, in > _api_call > return self._make_api_call(operation_name, kwargs) > File "/usr/lib/python3.5/site-packages/botocore/client.py", line 387, in > _make_api_call > operation_model, request_dict) > File "/usr/lib/python3.5/site-packages/botocore/endpoint.py", line 111, in > make_request > return self._send_request(request_dict, operation_model) > File "/usr/lib/python3.5/site-packages/botocore/endpoint.py", line 136, in > _send_request > request = self.create_request(request_dict, operation_model) > File "/usr/lib/python3.5/site-packages/botocore/endpoint.py", line 120, in > create_request > operation_name=operation_model.name) > File "/usr/lib/python3.5/site-packages/botocore/hooks.py", line 226, in > emit > return self._emit(event_name, kwargs) > File "/usr/lib/python3.5/site-packages/botocore/hooks.py", line 209, in > _emit > response = handler(**kwargs) > File "/usr/lib/python3.5/site-packages/botocore/signers.py", line 90, in > handler > return self.sign(operation_name, request) > File "/usr/lib/python3.5/site-packages/botocore/signers.py", line 123, in > sign > signature_version) > File "/usr/lib/python3.5/site-packages/botocore/signers.py", line 153, in > get_auth_instance > kwargs['credentials'] = self._credentials.get_frozen_credentials() > AttributeError: 'NoneType' object has no attribute 'get_frozen_credentials' > ====================================================================== > ERROR: setUpClass (tests.integration.test_s3transfer.TestS3Transfers) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File > "/builddir/build/BUILD/s3transfer-0.0.1/tests/integration/test_s3transfer. > py", line 118, in setUpClass > CreateBucketConfiguration={'LocationConstraint': cls.region}) > File "/usr/lib/python3.5/site-packages/botocore/client.py", line 301, in > _api_call > return self._make_api_call(operation_name, kwargs) > File "/usr/lib/python3.5/site-packages/botocore/client.py", line 387, in > _make_api_call > operation_model, request_dict) > File "/usr/lib/python3.5/site-packages/botocore/endpoint.py", line 111, in > make_request > return self._send_request(request_dict, operation_model) > File "/usr/lib/python3.5/site-packages/botocore/endpoint.py", line 136, in > _send_request > request = self.create_request(request_dict, operation_model) > File "/usr/lib/python3.5/site-packages/botocore/endpoint.py", line 120, in > create_request > operation_name=operation_model.name) > File "/usr/lib/python3.5/site-packages/botocore/hooks.py", line 226, in > emit > return self._emit(event_name, kwargs) > File "/usr/lib/python3.5/site-packages/botocore/hooks.py", line 209, in > _emit > response = handler(**kwargs) > File "/usr/lib/python3.5/site-packages/botocore/signers.py", line 90, in > handler > return self.sign(operation_name, request) > File "/usr/lib/python3.5/site-packages/botocore/signers.py", line 123, in > sign > signature_version) > File "/usr/lib/python3.5/site-packages/botocore/signers.py", line 153, in > get_auth_instance > kwargs['credentials'] = self._credentials.get_frozen_credentials() > AttributeError: 'NoneType' object has no attribute 'get_frozen_credentials' > ---------------------------------------------------------------------- > Ran 171 tests in 2.135s > FAILED (errors=2) I've tried on F23 and no errors were raised, while on F24 one error occured (probably due to the new python-tests configs and I reported it upstream (https://github.com/boto/s3transfer/issues/8) to figure out with them the problem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review