[Bug 1278964] Review Request: distro-info - Provides information about releases of Debian and Ubuntu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1278964



--- Comment #4 from Michael Kuhn <suraia@xxxxxxxxx> ---
> - Please add a comment (# foo) above: "%make_install VENDOR=ubuntu" why you
> use VENDOR=ubuntu
> here

I have solved this differently now. This was needed because the Makefile
installs a symlink to $VENDOR-distro-info and there is no fedora-distro-info. I
have now disabled the installation of this symlink.

> - license text not in %files as %license, please add:
> %license debian/copyright
> to %files for all (sub)packages. Note normally you would only add a %license
> line to %files for the main pkg, but since the different sub-pkgs do not
> interdepend here (and there is no main pkg), you need to add it to all
> sub-pkgs.

Done.

> - Does not own all directories that it creates: Does not own the
> %{perl_vendorlib}/Debian dir

Done.

> If you can create a -2 srpm fixing these 3 issues, then we should be good to
> go wrt this pkg.

Spec: https://ikkoku.de/~suraia/distro-info/distro-info.spec
SRPM: https://ikkoku.de/~suraia/distro-info/distro-info-0.14-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]