https://bugzilla.redhat.com/show_bug.cgi?id=1278963 --- Comment #3 from Michael Kuhn <suraia@xxxxxxxxx> --- Thanks for your review! > - license text not in %files as %license, please add: > %license debian/copyright > to %files Done. > - Does not own all directories that it creates, in specfiles pkg-specific > directories must be part of %files, so that they get removed when the pkg > gets removed, to do this simply change: Done. I did it like this because distro-info already owns this directory. Is it a problem that both packages do so now? > If you can create a 0.28-2 srpm fixing these 2 issues, then we should be > good to go wrt this pkg. > > Note as said please do a -2 and add a %changelog entry for the changes. > During Fedora pkg-review we always bump the Release field and add a > changelog entry when doing a new version, rather then keeping the release at > 1 during the entire review process. So when you did the new dput-ng pkg > which adds distro-data as dependency you should have made that > dput-ng-1.10-2, no need to fix this now, but please always bump Release when > doing new versions during pkg-review from now on. Sorry about that. I was somehow under the impression that the Release should be kept at 1. :-) I have uploaded new versions here: Spec: https://ikkoku.de/~suraia/distro-info-data/distro-info-data.spec SRPM: https://ikkoku.de/~suraia/distro-info-data/distro-info-data-0.28-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review