https://bugzilla.redhat.com/show_bug.cgi?id=1278963 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #2 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Full review done: Good: ==== - rpmlint checks return: distro-info-data.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. This warning can safely be ignored - package meets naming guidelines - package meets packaging guidelines - license (ISC) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Needs work: ======= - license text not in %files as %license, please add: %license debian/copyright to %files - Does not own all directories that it creates, in specfiles pkg-specific directories must be part of %files, so that they get removed when the pkg gets removed, to do this simply change: %{_datadir}/distro-info/* into: %{_datadir}/distro-info rpmbuild will then automatically make the pkg own the directory and include all files under the dir in the pkg, alternatively you could write: %dir %{_datadir}/distro-info %{_datadir}/distro-info/* This latter form is mostly useful if you do not want to include all files under the dir in a (sub)pkg If you can create a 0.28-2 srpm fixing these 2 issues, then we should be good to go wrt this pkg. Note as said please do a -2 and add a %changelog entry for the changes. During Fedora pkg-review we always bump the Release field and add a changelog entry when doing a new version, rather then keeping the release at 1 during the entire review process. So when you did the new dput-ng pkg which adds distro-data as dependency you should have made that dput-ng-1.10-2, no need to fix this now, but please always bump Release when doing new versions during pkg-review from now on. Regards, Hans -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review